@julian said in Rocket.Chat SSO + embed plugin for Nodebb:
@volanar contact us at [email protected] and we can discuss details 🙂
Done
It would be nice if we can preview themes in advance.
What do you mean? We have ACP -> Customize -> Themes, where you can see the themes, what do you want to see?
Can you draw a mockup of what you're thinking or describe it in more detail?
My suggestion:
Separate theme and plugin pages.
ACP -> Customize -> Themes -> Install
ACP -> Customize -> Themes -> Uninstall
ACP -> Customize -> Themes -> Preview
ACP -> Customize -> Themes -> Apply Theme
Real preview without rebooting or waiting for over 5 seconds/theme.
Provide filters(style, color, etc)
@ailion what you're asking for is by no means trivial and is impossible with the way themes work. We'd have to run a build cycle to display the theme anyways so you may as well just do it yourself.
fine
Thanks for GPL license
@ailion I hope you didn't misunderstand me, by "do it yourself" I was referring to trying out themes.
@ailion said in Separate theme from plugin:
Real preview without rebooting or waiting for over 5 seconds/theme.
Yeah, this is a real problem that I don't think can be solved by wishing it to happen. Not all things are possible with programming, unfortunately; there are real world constraints we have to live with.
AFAIK the current themes require processing since they need to be compiled to CSS that the browser understands, and that requires time. What is sacrificed in time is gained in modularity and composability, which I think is quite a fair tradeoff, unless you plan on changing the CSS constantly (several times a day). This is a scenario I've seen too, but the way to solve it is extremely complex.
But by all means, if you can pull it off, more power to you!