[nodebb-plugin-reactions] Reactions plugin for NodeBB

DownPW

hmm already done

josef

Maybe @baris will be able to explain why this was caused..

DownPW

ok yes no problem

DownPW

This post is deleted!

josef

@DownPW I didn't understand, did it get fixed for you? If so, how?

DownPW

no no I wait the answer of @baris

<baris>

Try moving the plugin after the theme in /admin/extend/plugins. There is a Order active plugins button there. After moving it rebuild and restart nodebb. Reactions plugin needs to be after the theme in plugin loading order.

DownPW

@baris

that's works. simple and good to know. I got pissed off over nothing.
Thanks for the help

phenomlab

@baris not sure if anyone else has reported this, but if you add a reaction to a post, general speed in terms of loading posts gains an unwanted 2 second lag which you can only get rid of by reloading the page?

EDIT - this same issue happens actually on using any Emoji from nodebb-plugin-emoji so letting @PitaJ know also

DownPW

@baris

I see this on nodebb console when I click on the + to add a reaction

julian

Please keep in mind this is a third party plugin, so it is not up to @baris to fix

josef

@DownPW What is your nodebb version?
Because mine works fine, v3.2

DownPW

@julian sorry for that
@josef 3.2.3

Reaction work fine but I see this in console like explain above

dave1904

This is really a plugin with great potential that is used a lot in our forum. But I am missing some elements:

notifications of how and by whom a post was reacted to. Currently you only see this when you go back to your post.
on a mobile device you can not see who all has reacted to a post. You can see the number but not by whom. You can only tap on the reaction and then react as well. A listing as with Likes would be nice.
I would like to see a separate selection of reaction emojis, not identical to the (custom) emojis list. I'm thinking of providing only 3-5 emojis to react.

@julian is it still possible that you reintroduce another reactions plugin?

phenomlab

@dave1904 I'm with you on this. My biggest issue is the really bizarre 2 second delay it adds to actions in the forum after you use it which can only be shaken off with a site reload in the browser.

julian

@dave1904 depending on feasibility it may be easier to build this in to the emoji plugin.

dave1904

@julian The problem I see is that the actually very cool feature of linking a reaction to reputation is not clear with the mass of emojis unless you add a rule to each emoji. I already have over 60 custom emojis, plus the standard emojis. Also, why should you be able to react to a post with a mountain cableway emoji. .

The idea I have is to completely dispense with upvotes and instead regulate reputation solely through a few reactions. Thumbs up , thank you , helpful - something like that.

But I completely understand your point about the previous way being easier. I think the first two points are much more important anyway, as I've received quite a few inquiries about why there are no notifications on reactions and the presentation on mobile devices.

<baris>

Published a new version(2.1.6) of this plugin for NodeBB 3.3.0

Changes:

Update acp with the new design
Add chat message reactions
Ability to toggle reaction support on posts/chats from the ACP
Optimized loading of data, tooltips are only created if you mouseover a reaction instead of loading every single user who reacted on page load.

dave1904

I'm trying to implement basic notification for this plugin.

In the library.js I've added the following code after await Promise.all([...]);.

const notifications = require.main.require('./src/notifications');
...
SocketPlugins.reactions = {
	addPostReaction: async function (socket, data) {
...

await Promise.all([
	db.setAdd(`pid:${data.pid}:reactions`, data.reaction),
	db.setAdd(`pid:${data.pid}:reaction:${data.reaction}`, socket.uid),
]);

// Get the author id
const postOwnerUid = await posts.getPostField(data.pid, 'uid');
console.log(`postOwnerUid: ${postOwnerUid}`);
// Create and send notification
if (postOwnerUid && postOwnerUid !== socket.uid) {
	console.log(`Attempting to create notification for postOwnerUid: ${postOwnerUid}`);
	await notifications.create({
		bodyShort: `User ${socket.uid} has reacted with ${data.reaction} to your post`,
		nid: `user:${socket.uid}:reacted:${data.pid}`,
		pid: data.pid,
		uid: postOwnerUid,
		tid: data.tid,
		from: socket.uid,
		path: `/post/${data.pid}`
	});
	console.log('Notification created successfully');

	console.log(`Attempting to push notification for postOwnerUid: ${postOwnerUid}`);
	await notifications.push(`user:${socket.uid}:reacted:${data.pid}`, [postOwnerUid]);
	console.log('Notification pushed successfully');
}

In the log it seems fine (at least without any errors):

postOwnerUid: 8
Attempting to create notification for postOwnerUid: 8
Notification created successfully
Attempting to push notification for postOwnerUid: 8
Notification pushed successfully

But I receive no notifications so there must be something wrong. I'm not very familiar with JS yet so console.log is the only way I know to "debug" my code. Help would be appreciated.

julian

@dave1904 The first argument of notifications.push takes the entire notification object, which is what is returned from notifications.create

We should probably add some sanity checks in case you pass in an incorrect format to notifications.push, heh.