Hard fix
I`m remove this folder from node_modules and upgrade nodebb..
What was it?
[nodebb-plugin-reactions] Reactions plugin for NodeBB
-
I forked the plugin to https://github.com/NodeBB-Community/nodebb-plugin-reactions, @Antosik can send the PR there then I will merge and publish as
@nodebb/nodebb-plugin-reactions -
-
Does this plugin work on 19.2?
-
-
@phenomlab I tried to install it and error codes popped up. So, it's not working.
-
zmih Yes, there is a pending fork from @Antosik that is required before this will work.
-
Published
@nodebb/[email protected]This includes the changes from @Antosik so it has a breaking change for themes. To add support in your custom theme include this where you want the reactions to show up.
<!-- IMPORT partials/topic/reactions.tpl -->For example https://github.com/NodeBB/nodebb-theme-persona/commit/8cbad331ff9c8abe23e2a9a6d02d637857acbd2f
-
@baris Seems there's an issue with this. Once installed, it cannot be removed (comes up with an error in the admin page)
I'm also unable (it seems) to remove using
npm removefrom the CLI.I'm using v2 of NodeBB in dev (not prod obviously).
-
@phenomlab please open an issue on our gh, seems like an issue with that api route and scoped packages.
-
@baris Will do. Thanks
-
-
How to install for test ?
I have test
npm i @nodebb/nodebb-plugin-reactionsbut I have error :npm i @nodebb/nodebb-plugin-reactions npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: [email protected] npm ERR! Found: [email protected] npm ERR! node_modules/nodebb-plugin-emoji npm ERR! [email protected]"4.0.2" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer [email protected]"^3.5.0" from @nodebb/[email protected] npm ERR! node_modules/@nodebb/nodebb-plugin-reactions npm ERR! @nodebb/[email protected]"*" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution. npm ERR! npm ERR! See /home/nodebb/.npm/eresolve-report.txt for a full report. -
hi @baris , is the forked version published? I think on ACP, I can only see the old version of the plugin?
-
Forked version is published as
@nodebb/nodebb-plugin-reactions -
@baris having tested this before, it doesn't seem to work and cannot be uninstalled. Any update on this please ?
-
Uninstalling scoped packages from ACP is broken https://github.com/NodeBB/NodeBB/issues/10582.
You can uninstall from the CLI with
npm uninstall @nodebb/nodebb-plugin-reactionsclosed cannot uninstall scoped packages from the ACP #10582
-
@baris that doesn't work either - at least, not when I tested it last.
EDIT: Just tried again and it's working from the CLI
-
@baris I now have this working in 1.19.7 - thanks
-
@DownPW Were you able to find a fix for this? Just ran into this issue as well:
npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: [email protected] npm ERR! Found: [email protected] npm ERR! node_modules/nodebb-plugin-emoji npm ERR! [email protected]"4.0.2" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer [email protected]"^2.2.0" from [email protected] npm ERR! node_modules/nodebb-plugin-reactions npm ERR! [email protected]"*" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution. npm ERR! npm ERR! See /home/nodebb/.npm/eresolve-report.txt for a full report. npm ERR! A complete log of this run can be found in: npm ERR! /home/nodebb/.npm/_logs/2022-05-24T19_48_05_893Z-debug-0.log -
@Tez same here in nodeBB 2.0.1
