We're encountering a couple of issues with zen mode on our platform that I could reproduce with community.nodebb.org as well:
Since latest Chrome update (Version 71.0.3578.98 (Official Build) (64-bit) and above)
Zen mode button doesn't work anymore.
It's working with Edge, Safari and Firefox though.
Can you fix it or does Chromium/Chrome need to do it?
When zen mode is activated then:
clicking emoji button doesn't produce anything
it's not possible to submit a topic or a post in zen mode
Regarding the duplicate/canonical URL issue. I'm really not sure what the right answer is. Maybe it's fine the way it is, maybe the canonical URL should be the expanded version (then the sitemap might change a lot causing other SEO issues). I just wanted to bring it up for discussion.
This is because NodeBB uses a hidden class to hide the opposite value (lock/unlock) so focus is lost when going over the hidden element.
This could be fixed by using a hidden attribute on the <li> element but the toggleClass code is in NodeBB core not the theme code.
There is a need to fix this because accessibility by keyboard is important for some disabled or without-mouse users.
NodeBB-Version: v1.10.2 (GitHub master)
Docker: 18.09.0, build 4d60db4
Language: German (de-DE)
Installation directory: /usr/src/app
When building a NodeBB docker image, following warning appear. Maybe it would be good if NodeBB would update these:
npm WARN deprecated email@example.com: CircularJSON is in maintenance only, flatted is its successor.
npm WARN deprecated firstname.lastname@example.org: This version is no longer maintained. Please upgrade to the latest version.
npm WARN deprecated email@example.com: This version is no longer maintained. Please upgrade to the latest version.
npm WARN deprecated firstname.lastname@example.org: This version is no longer maintained. Please upgrade to the latest version.
npm WARN lifecycle email@example.com~install: cannot run in wd firstname.lastname@example.org neon build >> build.log 2>&1 || exit 0 (wd=/usr/src/app/node_modules/benchpressjs/rust/benchpress-rs)
npm notice created a lockfile as package-lock.json. You should commit this file.
What's happening is that if a relative path is detected in a markdown url, this code checks that the relative path prefix is there. I'm not really sure why this is the case. If I'm running Wordpres (I am) and upload images there, shouldn't I be able to use relative URLs without enforcing the relative_path?